Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support error codes / typed errors #36

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Support error codes / typed errors #36

merged 2 commits into from
Jul 19, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 16, 2020

This will allow returning more actionable errors from RPC calls - e.g. 'balance too low' when pushing messages

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! The chief limitation is that it doesn't work for wrapped errors, which is a problem for a lot of Lotus's use-cases. But I don't think we should block this 2 year old PR on that!

@arajasek arajasek merged commit 9918975 into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants