chore: include manifest & proof in make gen; add extra proof types
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
approved these changes
Jul 11, 2024
|
@rvagg This looks straight forward. Please merge when ready. |
Merged
ZenGround0
approved these changes
Jul 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
=========================================
- Coverage 3.58% 3.57% -0.02%
=========================================
Files 520 520
Lines 96648 96959 +311
=========================================
Hits 3468 3468
- Misses 91829 92140 +311
Partials 1351 1351
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
manifestline in Makefile is included in #283 because it's needed to get past new linting. Butproofis not included there and I wanted to serialise a couple of the Aggregate types in there for debugging but they don't yet have cbor-gen additions. We don't strictly need these for communication between lotus and actors, but they are handy to have for debugging!