Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simple migration nv25 #325

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Nov 11, 2024

Closes: #321

Add the simple migration nv25, can be opened after the nv25 skeleton has been merged: #324

chore: create base nv25 skeleton
chore: delete migration specific for nv24
chore: add simple migration nv25
@rjan90 rjan90 force-pushed the phi/add-simple-migration-nv25 branch from cc097ca to d20ee1a Compare November 18, 2024 14:51
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (7698395) to head (d20ee1a).

Files with missing lines Patch % Lines
builtin/v16/migration/top.go 0.00% 61 Missing ⚠️
builtin/v16/migration/system.go 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage    3.39%    3.39%   -0.01%     
==========================================
  Files         660      662       +2     
  Lines      177742   177818      +76     
==========================================
  Hits         6041     6041              
- Misses     169852   169928      +76     
  Partials     1849     1849              
Files with missing lines Coverage Δ
builtin/v16/migration/system.go 0.00% <0.00%> (ø)
builtin/v16/migration/top.go 0.00% <0.00%> (ø)

@rjan90 rjan90 marked this pull request as ready for review November 18, 2024 15:02
@rjan90 rjan90 requested a review from masih November 18, 2024 15:02
@rjan90 rjan90 merged commit 0e34cf7 into master Nov 18, 2024
8 checks passed
@rjan90 rjan90 deleted the phi/add-simple-migration-nv25 branch November 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton for nv25 to support development and
3 participants