Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure available port for test server #295

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 6, 2023

Closes: #293

why not just do it eh?

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #295 (c0c09f7) into main (2edae8b) will increase coverage by 0.16%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   72.52%   72.69%   +0.16%     
==========================================
  Files          68       68              
  Lines        6203     6218      +15     
==========================================
+ Hits         4499     4520      +21     
+ Misses       1456     1453       -3     
+ Partials      248      245       -3     
Impacted Files Coverage Δ
pkg/internal/itest/testpeer/generator.go 70.90% <75.00%> (+0.12%) ⬆️

... and 5 files with indirect coverage changes

@hannahhoward hannahhoward merged commit 40caed5 into main Jun 6, 2023
@hannahhoward hannahhoward deleted the rvagg/available-port branch June 6, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with "port already in use" flaky CI failures
3 participants