Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back pprof endpoints #300

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix: add back pprof endpoints #300

merged 1 commit into from
Jun 7, 2023

Conversation

kylehuntsman
Copy link
Contributor

@kylehuntsman kylehuntsman commented Jun 7, 2023

Looks like the pprof endpoints were accidentally removed in PR #286 while removing the metrics server and prometheus exporter. This commit adds them back to the HttpServer. Closes #297.

Looks like the pprof endpoints were accidentally removed in PR #286 while removing the metrics server and prometheus exporter. This commit adds them back to the HttpServer. Closes #297.
@kylehuntsman kylehuntsman force-pushed the fix/pprof-endpoints branch from d8a1d21 to c0351a9 Compare June 7, 2023 15:58
@codecov-commenter
Copy link

Codecov Report

Merging #300 (c0351a9) into main (fe9e760) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   72.55%   72.14%   -0.42%     
==========================================
  Files          68       68              
  Lines        6217     6224       +7     
==========================================
- Hits         4511     4490      -21     
- Misses       1458     1478      +20     
- Partials      248      256       +8     
Impacted Files Coverage Δ
pkg/server/http/server.go 85.41% <100.00%> (+2.48%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 3f0f2da into main Jun 7, 2023
@hannahhoward hannahhoward deleted the fix/pprof-endpoints branch June 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable pprof
3 participants