-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract go-trustless-utils; and more improvements discovered along the way #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 77.00% 75.77% -1.23%
==========================================
Files 87 84 -3
Lines 6700 6228 -472
==========================================
- Hits 5159 4719 -440
+ Misses 1267 1258 -9
+ Partials 274 251 -23
|
willscott
approved these changes
Sep 1, 2023
rvagg
force-pushed
the
rvagg/trustless-utils
branch
from
September 7, 2023 05:59
0767fa1
to
78dc756
Compare
Updated to ipld/go-trustless-utils#6 (will need to update again on tag) |
* removes "car-scope" handling * minor changes to selector building for entity-bytes non-entity dag-scope * improved error messages * refactored traversal out of bitswapretriever * major refactor/cleanup-reorg in /ipfs/ daemon handler * return "bytes" in "Accept-Ranges" header
rvagg
force-pushed
the
rvagg/trustless-utils
branch
from
September 8, 2023 05:05
78dc756
to
cf96aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary things now in https://github.com/ipld/go-trustless-utils are:
DagScope
,ByteRange
and aRequest
type has been extracted that's a subset of what's now calledRetrievalRequest
here; the difference being thatRequest
represents a Trustless Gateway request, whileRetrievalRequest
has lots of lassie extras on it.Other things done in here, much of which was discovered while doing the extraction:
dups
parameter in content-type of HTTP remotes and handle accordinglyIncludes some of the work I did in #386 around the traversal stuff — including collecting the
LastPath
so it can be dealt with elsewhere. I'm not currently using it here but I am using it in Frisbii to log cases where the requested path couldn't be completed in the DAG; I'll do the same here soon too for the CLI and close #386 out.