fix: log unknown actor type without returning error #1169
Conversation
lens/util/repo.go
Outdated
| @@ -185,7 +185,8 @@ func MethodAndParamsForMessage(m *types.Message, destCode cid.Cid) (string, stri | |||
|
|
|||
| params, method, err := ParseParams(m.Params, m.Method, destCode) | |||
| if method == "Unknown" { | |||
| return "", "", fmt.Errorf("unknown method for actor type %s: %d", destCode.String(), int64(m.Method)) | |||
There was a problem hiding this comment.
I'm not sure this is the correct behavior if a method is unknown. I don't think we can write empty strings to models that expect a method name. One option would be to remove returning the name of the method being called here, and instead post process tables needing a method name string. cc @birdychang
There was a problem hiding this comment.
Why not just put ‘unknown’ as the method name?
There was a problem hiding this comment.
We can always post process later. Also, don’t we wanna deprecate parsed messages? I don’t really care about the model. Let’s make it work first.
There was a problem hiding this comment.
Or just store the method code as the method name here. There’s should be separate columns in case it fails to lookup the name.
There was a problem hiding this comment.
Store the method in string format.
Don't error on unknown method numbers for FEVM.
Due to the previous fix, it will return the
Unknownmethod, then cause the error inparsed_message. Therefore, we can use the same logic asvm_message: logging the error without returning error.