Proposal to start a deal with the price that a client is willing to pay for the storage space

[jennijuju]

Right now, the ClientStartDeal is taking a price a client is willing to pay per epoch to store the entire deal, regardless of size.

From a client's perspective, if they know the miner's ask price, which is in attoFIL/GiB/epoch, to make a good deal, they will have to calculate the most beneficial & acceptable price they want to pay according to their deal size. We also have some rounds up in epoch and deal size mechanism which makes this calculation harder.

Therefore, we'd like to propose to wrap the current ClientStartDeal, with a new API, like ClientStartDAGDeal with dataCID, price they are willing to pay, price unit of their choice(fil/byte/epoch or fil/GiB/epoch.. and etc), miner id, duration -> Then we will get the epoch price for them.

This way, a client can have the option to set the price they are willing to pay for the storage space(like cloud storage price list) or what they are willing to pay for the deal.

[pooja]

I'm a little bit confused. Isn't it the case currently that a client's deal proposal takes a price in FIL/GiB/epoch? At least, this is what I've seen every time I've stored a deal in the last few days.

[jennijuju]

I'm a little bit confused. Isn't it the case currently that a client's deal proposal takes a price in FIL/GiB/epoch? At least, this is what I've seen every time I've stored a deal in the last few days.

It’s not. I have confirmed with Hannah that on client side, the price is FIL/epoch for the deal and size doesn’t matter at all. If you look at the total price at the deal you can see it simply equals price(FIL/epoch)*epcoh.

[pooja]

If that's the case, then I think we need to revise this and move this to a different convention. As it is this is super cumbersome UX. More context in this thread: https://protocollabs.slack.com/archives/CKT1X7YFN/p1603049955423200

cc @hannahhoward @ribasushi Let's hash it out here please!

[ingar]

One potential point of confusion, and this should be addressed in the help text for the CLI, is that all arguments that take a “price” can actually take AttoFIL or FIL arguments. These are equivalent:

# default is parsed as FIL
--price 0.000000000000000123 

# explicit FIL units
--price .000000000000000123 FIL

# specify as attofil
--price 123 attofil
--price 123AFIL

Case-insensitive and the space between the amount and unit is optional. That the underlying code uses an big.Int or abi.TokenAmount matters less. The CLI code will parse it into the correct type.

[jennijuju]

After a discussion wit product team, we think it makes more sense to keep all prices in attoFIL when user interaction is related. (that being said, we dont want to give unit options, just to avoid unnecessary confusion

[jennijuju]

Closing since this is no longer a product requirement, @dineshshenoy feel free to reopen the issue if there is a need!

[arajasek]

Good candidate to be fixed in the v1 API changeset.

[TippyFlitsUK]

Hi 👋

The Legacy Lotus Markets sub-system reached EOL at the end of the 31st January 2023.

This ticket is being marked as won't fix and closed as the Lotus Team will no longer be making any further fixes or enhancements to the legacy markets subsystem.

Please feel free to re-open this ticket in the new Boost markets sub-system repository at https://github.com/filecoin-project/boost if you feel that it is still relevant.

Many thanks 🙏