update markets with pricing fix, and improve docs #5629
Conversation
There was a problem hiding this comment.
LGTM 👍
The current version of markets v1.1.8 caused issues when lotus clients on a previous version of markets tried to propose a deal with lotus miners on v1.1.8: #5608
whyrusleeping/cbor-gen#50 should fix the issue. @whyrusleeping could you review it please?
There was a problem hiding this comment.
This is API breaking, at the very least we should change the field name, maybe adding fallback to current behavior. Keeping it this way can cause people to make deals for way more FIL than they intended to
(interactive mode price math on L815 needs fixing)
Co-authored-by: dirkmc <dirkmdev@gmail.com>
|
@magik6k i can't imagine anyone actually uses an interface this broken for anything. The worst case is that someone pays 32 times more than they were expecting for a 32GB deal. I dont even think anyone has successfully made a 32gb deal using this interface. One easy thing we can do is to put a little warning if the users price is above the miners listed ask price by 2x, and force them to add a flag if they really want to pay that much |
|
Let's extract out the helptext from this, but drop the (now-irrelevant) markets update |
pulling in filecoin-project/go-fil-markets#491 for less nonsensical deal pricing