Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSyncManagerEdgeCase is flaky #4829

Closed
magik6k opened this issue Nov 12, 2020 · 2 comments · Fixed by #5397
Closed

TestSyncManagerEdgeCase is flaky #4829

magik6k opened this issue Nov 12, 2020 · 2 comments · Fixed by #5397
Assignees
@schomatis
Labels
area/chain Area: Chain impact/test-flakiness Impact: Test Flakiness

Comments

@magik6k
Copy link
Contributor

magik6k commented Nov 12, 2020

https://app.circleci.com/pipelines/github/filecoin-project/lotus/11548/workflows/8973602b-3463-4b73-bf73-209441a9fa0f/jobs/91726

Failed
=== RUN   TestSyncManagerEdgeCase/edgeCase-1
2020-11-12T16:17:35.099Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmn [bafy2bzaceawuhqwcn2swwurijnu53wzwtfaqhsl2uxawmcx4zizyj3srwszrw]
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:217	selected initial sync target: [bafy2bzaceawuhqwcn2swwurijnu53wzwtfaqhsl2uxawmcx4zizyj3srwszrw]
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmn [bafy2bzacealyjtdey2gc3jwtry6dpzqdk6mbejs6rr3zfu2xxpskzsfpqvewc]
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmn [bafy2bzacedzfz6x2gubuhukqtl322fy7loa5bxpvk2rlclvzvvpkcm2qwhpnk]
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:313	worker 0 syncing in [bafy2bzaceawuhqwcn2swwurijnu53wzwtfaqhsl2uxawmcx4zizyj3srwszrw]
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:321	worker 0 done; took 4.919µs
2020-11-12T16:17:35.100Z	�[34mINFO�[0m	chain	chain/sync_manager.go:271	selected sync target: [bafy2bzacedzfz6x2gubuhukqtl322fy7loa5bxpvk2rlclvzvvpkcm2qwhpnk]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:313	worker 1 syncing in [bafy2bzacedzfz6x2gubuhukqtl322fy7loa5bxpvk2rlclvzvvpkcm2qwhpnk]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmo [bafy2bzaceb2wbhnnkeadq767nioqlvhacek7ec6c64vusvlj3nsbdjeqdz3ru]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmo [bafy2bzacebmnotv2zcl2sl6sfotljitudu2xymwmit4trbomg2ms3pwn2uixw]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:231	selected sync target: [bafy2bzacebmnotv2zcl2sl6sfotljitudu2xymwmit4trbomg2ms3pwn2uixw]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmp [bafy2bzacedzfz6x2gubuhukqtl322fy7loa5bxpvk2rlclvzvvpkcm2qwhpnk]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:321	worker 1 done; took 363.097µs
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:197	new peer head: DgUrnmn [bafy2bzaceawuhqwcn2swwurijnu53wzwtfaqhsl2uxawmcx4zizyj3srwszrw]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:271	selected sync target: [bafy2bzaceb2wbhnnkeadq767nioqlvhacek7ec6c64vusvlj3nsbdjeqdz3ru]
2020-11-12T16:17:35.101Z	�[34mINFO�[0m	chain	chain/sync_manager.go:313	worker 3 syncing in [bafy2bzaceb2wbhnnkeadq767nioqlvhacek7ec6c64vusvlj3nsbdjeqdz3ru]
    sync_manager_test.go:121: Expected tipset [bafy2bzacebmnotv2zcl2sl6sfotljitudu2xymwmit4trbomg2ms3pwn2uixw] to sync, but got [bafy2bzaceb2wbhnnkeadq767nioqlvhacek7ec6c64vusvlj3nsbdjeqdz3ru]
    --- FAIL: TestSyncManagerEdgeCase/edgeCase-1 (0.00s)

Failed
=== RUN   TestSyncManagerEdgeCase
    sync_manager_test.go:83: a: [bafy2bzaceawuhqwcn2swwurijnu53wzwtfaqhsl2uxawmcx4zizyj3srwszrw]
    sync_manager_test.go:85: b1: [bafy2bzacealyjtdey2gc3jwtry6dpzqdk6mbejs6rr3zfu2xxpskzsfpqvewc]
    sync_manager_test.go:87: b2: [bafy2bzacedzfz6x2gubuhukqtl322fy7loa5bxpvk2rlclvzvvpkcm2qwhpnk]
    sync_manager_test.go:89: c1: [bafy2bzacebmnotv2zcl2sl6sfotljitudu2xymwmit4trbomg2ms3pwn2uixw]
    sync_manager_test.go:91: c2: [bafy2bzaceb2wbhnnkeadq767nioqlvhacek7ec6c64vusvlj3nsbdjeqdz3ru]
    sync_manager_test.go:93: d1: [bafy2bzacea32d73lk3pl6nd6buf7zhvwxuttojjycpscyzt5uon4uqwwkjb5u]
    sync_manager_test.go:95: e1: [bafy2bzacecxkvuo2yilrb4d2qzhjcrud7uk4d63g4ekhchmhuufrmcquxe4og]
--- FAIL: TestSyncManagerEdgeCase (0.00s)
@magik6k magik6k added the impact/test-flakiness Impact: Test Flakiness label Nov 12, 2020
@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 14, 2020

it is super common

@schomatis schomatis mentioned this issue Jan 11, 2021
Closed
@schomatis
Copy link
Contributor

Assigning myself as part of #5313.

@schomatis schomatis self-assigned this Jan 11, 2021
@schomatis schomatis added the area/chain Area: Chain label Jan 11, 2021
@magik6k magik6k linked a pull request Jan 21, 2021 that will close this issue
fix a flake in the sync manager edge case test #5397
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
area/chain Area: Chain impact/test-flakiness Impact: Test Flakiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix a flake in the sync manager edge case test filecoin-project/lotus
3 participants
@Kubuxu @magik6k @schomatis