Refactor Sync tests #5313
Closed
Refactor Sync tests #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the central point of information and placeholder for WIP notes on an effort to refactor some parts of the sync test logic and more clearly expose the validations taking place.
With no clear plan at the moment the basic intuition is to more clearly decouple between:
much of which is now under the umbrella of the Sync API.
Need to review flaky test #4829 after refactoring.
#5328: streamline sync top-level calls to reflect states. This helps moving validations in
syncMessagesAndCheckStatecloser to the surface to start giving them an entity of their own.#5370
#4624