M1: miner with 2k deals but 0 migrated to dagstore

[raulk]

Checklist

• This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
• I am reporting a bug w.r.t one of the M1 tags. If not, choose another issue option here.
• I am not reporting a bug around deal making. If yes, create a M1 Bug Report For Deal Making.
• I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.

Lotus component

Other

Lotus Tag and Version

m1.3.4

Describe the Bug

Miner has 2697 deals:

2021-08-11T00:46:06.057+0900	INFO	dagstore.migrator	dagstore/wrapper.go:286	registering shards for all active deals in sealing subsystem	\{"count": 2697\}\

However, the migrator reports a nil PieceCID for all deals:

2021-08-11T00:46:06.057+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 2202633\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 2252899\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\
2021-08-11T00:46:06.058+0900	WARN	dagstore.migrator	dagstore/wrapper.go:335	deal has nil piece CID; skipping	\{"deal_id": 0\}\

Leading to all deals being skipped on migration:

2021-08-11T00:46:06.095+0900	INFO	dagstore.migrator	dagstore/wrapper.go:361	finished registering all shards	\{"total": 0\}\

And a total of 0 deals migrated to the dagstore.

Logging Information

See above.

Repo Steps

No response

[raulk]

Found the bug on a debugging session with @hannahhoward.

This check is incorrect:

lotus/markets/dagstore/wrapper.go

Line 334 in 6e6b1ec

if deal.Ref.PieceCid == nil {

We should be using deal.Proposal.PieceCID, which is guaranteed to be non-nil.

It is not clear to me why this hadn't been reported up until now.

[raulk]

Fixed in d3cf5b0.