Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth JSON-RPC: from in eth_getTransactionByHash is not correctly popul… #10151

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Eth JSON-RPC: from in eth_getTransactionByHash is not correctly popul… #10151

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
070aca2
Eth JSON-RPC: from in eth_getTransactionByHash is not correctly popul…
maciejwitowski Jan 31, 2023
5f2ef98
Move assigning `from` address to the API level
maciejwitowski Jan 31, 2023
dcbfca5
Improve the error message
maciejwitowski Jan 31, 2023
99b879d
Add test for EthGetTransactionByHash
arajasek Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions node/impl/full/eth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,6 +1571,13 @@ func newEthTxFromSignedMessage(ctx context.Context, smsg *types.SignedMessage, s
if err != nil {
return ethtypes.EthTx{}, err
maciejwitowski marked this conversation as resolved.
Show resolved Hide resolved
}

fromAddr, err := lookupEthAddress(ctx, smsg.Message.From, sa)
if err != nil {
return ethtypes.EthTx{}, xerrors.Errorf("failed to resolve Ethereum address: %w", err)
}

tx.From = fromAddr
} else if smsg.Signature.Type == crypto.SigTypeSecp256k1 { // Secp Filecoin Message
tx = ethTxFromNativeMessage(ctx, smsg.VMMessage(), sa)
tx.Hash, err = ethtypes.EthHashFromCid(smsg.Cid())
Expand Down