Make message wait work, use it for storage miner init #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Jul 29, 2019
|
|
||
| // create actors and stuff | ||
| // TODO: persist this address in the storage-miner repo | ||
| log.Infof("New storage miners address is: %s", addr) |
There was a problem hiding this comment.
That's the worker address from params, isn't it? (The one we generate few lines above - https://github.com/filecoin-project/go-lotus/pull/103/files#diff-9e20bebb13ea36c4a8ae7c31d606791bR104-R113)
There was a problem hiding this comment.
Its actually going to be the address created for the new miner actor, the worker address gets put inside the actors state, and that actors address gets returned to us.
There was a problem hiding this comment.
Oh, right. This feels a bit weird, but I can't think of anything better right now
magik6k
approved these changes
Jul 29, 2019
whyrusleeping
force-pushed
the
feat/msg-wait
branch
from
27c1b23
to
e59944b
Compare
nonsense
added a commit
that referenced
this pull request
Nov 6, 2020
upgrade lotus and plans to use buildbase:v4
dumikau
pushed a commit
to protofire/lotus
that referenced
this pull request
Jun 8, 2023
* add json rpc client * support onchain reconfiguration * use file membership by default * add compatibility test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage miner init now waits for the message it sends to get mined, and prints out the brand new miner actor address when it does! Excitement!