Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EthGetBalance: lookup balance at correct state #10358

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Feb 27, 2023

Related Issues

@raulk observed that some tooling was taken longer than expected to update balance. This is because the current EthBalance implementation uses the parent state of the input tipset, which is inconsistent with the Tipset <-> blockParam mapping we have.

Proposed Changes

  • Use the TipsetState of the input param
    • I considered extracting this into some helper, but there isn't any other use case of it (nor is it needed anywhere else in the EthAPI), and I think it'll confuse usage with the existing LoadActor methods.
  • Add a test

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner February 27, 2023 19:44
require.NoError(t, err)
require.Equal(t, int64(0), bal.Int64())

bal, err = client.EVM().EthGetBalance(ctx, ethAddr, strconv.FormatInt(int64(ml.Height-1), 10))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion fails without the change in this PR.

@arajasek arajasek mentioned this pull request Feb 27, 2023
21 tasks
@arajasek arajasek merged commit 4accfac into release/v1.20.0 Feb 27, 2023
@arajasek arajasek deleted the asr/fix-get-actor branch February 27, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants