Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post: Tune down default post-parallel-reads #10365

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Feb 28, 2023

Related Issues

fixes #9074

Proposed Changes

Tuning down the default post-parallel-reads to a conservative number. Seems more beneficial to be conservative here, and not cause any network timeouts, ending up in sectors being skipped. SPs can fine tune this value higher if their architectures can handle it.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Tuning down the default post-parallel-reads to a conservative number.
@rjan90 rjan90 requested a review from a team as a code owner February 28, 2023 09:29
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change

ParallelCheckLimit: 128,

Tune down ParallelCheckLimit config default
@magik6k magik6k merged commit 8142aaa into master Feb 28, 2023
@magik6k magik6k deleted the fix/tune-down-post-parallel-reads branch February 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the default post-parallel-reads value
2 participants