Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EthAPI: Correctly get parent hash #10389

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 3, 2023

Related Issues

#10385

Proposed Changes

The previous implementation was trying to load the tipset that is the genesis's parents, which is both wrong and unnecessary. Simplifing fixes #10385.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 3, 2023 21:44
@arajasek arajasek requested review from raulk and Stebalien March 3, 2023 21:45
@arajasek arajasek merged commit 12496e5 into master Mar 6, 2023
@arajasek arajasek deleted the asr/fix-eth-api-genesis branch March 6, 2023 14:15
@jennijuju jennijuju mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genesis block not retrievable through eth_getBlockByNumber / eth_getBlockByHash
5 participants