fix: itest: avoid failing the test when we race the miner #10461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been seeing quite a few tests failing here, so I'm hoping this will deflake them a bit.
|
Hypothesis: When we ended the test, the miner was still running and attempted to create one more block. This failed because the test was done and the lotus node shut down. Ideally all those "rpc error" checks should catch this, but apparently those aren't sufficient. Checking the context is a better catch-all solution. |
arajasek
approved these changes
Mar 13, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing quite a few tests failing here, so I'm hoping this will deflake them a bit.