Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consensus: log ApplyBlock timing/gas stats #10470

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 14, 2023

Related Issues

Proposed Changes

Log applyblock stats

Additional Info

Those metrics can be very useful for more detailed gas / block time analysis. Today we only have prometheus metrics, which are bucketed, and not too accurate due to that, and the "block validation" log, which usually doesn't include state compute, which most of the time is pre-computed.

Example output:

2023-03-14T10:16:59.748+0100    INFO    consensus-common        consensus/compute_state.go:496  ApplyBlocks stats       {"early": 0.00008036, "earlyCronGas": 0, "vmMsg": 2.428463637, "msgGas": 18247427215, "vmCron": 6.90146274, "cronGas": 126278836788, "vmFlush": 0.472160843, "epoch": "2682071", "tsk": "{bafy2bzacebyx3aten2gih4rokwrzg5qocalnllqslyu4xqvyqbu33hskjknos,bafy2bzacedvjoqkoj2utw3d5cyhb4bw4csrrkftdaf5mc3my54g3j77ots6oe,bafy2bzacedvr6fw3ctyiwrfdt65l65s3ybqf6tiiastqipdyt6rvb7ivj5k7u,bafy2bzaceaqfnv4jezbpsv54g3t7a5jcimbqk7b7h3lsncwmzh47smoofhw46}"}

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 14, 2023 09:19
@magik6k magik6k merged commit 162e07f into master Mar 14, 2023
@magik6k magik6k deleted the feat/applyblock-timing-log branch March 14, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants