Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #10472 to v1.21.0 #10475

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 14, 2023

Related Issues

Backports #10472 into v1.21.0

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 14, 2023 13:48
@Stebalien
Copy link
Member

We should consider a max walk height as an alternative (although @arajasek's tipset skiplist changes may change that?).

@jennijuju jennijuju added this to the v1.20.4 milestone Mar 15, 2023
@jennijuju jennijuju requested review from jennijuju and a team March 15, 2023 02:10
@magik6k
Copy link
Contributor Author

magik6k commented Mar 15, 2023

We should consider a max walk height as an alternative (although @arajasek's tipset skiplist changes may change that?).

Even with max walk height I believe having this special case for genesis is technically more correct (tho my node still syncs fine without it, so really it probably doesn't matter that much, beyond maybe marginal perf gain)

@arajasek arajasek merged commit 33e41ce into release/v1.21.0 Mar 15, 2023
@arajasek arajasek deleted the backport/v1.21.0/fix/slow-node-startup branch March 15, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants