[DO NOT MERGE] fix: ffi: make FVM validation concurrency configurable #10479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: 1. Set the default to 4. 2. Make it configurable with the `LOTUS_FVM_CONCURRENCY` environment variable.
arajasek
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
LGTM, but:
- also land in master please
- use the merge commit filecoin-project/filecoin-ffi@5ab95e3 instead?
|
Yes, but I don't think we can land anything till CircleCI comes back. |
|
Note: don't merge, we'll want this to land in the 1.20.0 release branch. Adding to that milestone for now. |
arajasek
changed the title
|
hiiiii gonna include in v1.21.0 - so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
LOTUS_FVM_CONCURRENCYenvironment variable.