Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth: handle a potential divide by zero in receipt handling #10495

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Stebalien
Copy link
Member

Related Issues

fixes #10471

Proposed Changes

This isn't really possible to hit on-chain at this piont (message won't be accepted) but we might as well be extra careful.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
    • Kind of annoying to test as lotus will reject the message.
  • CI is green

This isn't really possible to hit on-chain at this piont (message won't
be accepted) but we might as well be extra careful.

fixes #10471
@Stebalien Stebalien requested a review from a team as a code owner March 16, 2023 15:55
@Stebalien Stebalien requested a review from magik6k March 16, 2023 15:55
@Stebalien Stebalien mentioned this pull request Mar 16, 2023
7 tasks
@magik6k magik6k merged commit eed1a09 into master Mar 17, 2023
@magik6k magik6k deleted the steb/fix-div-by-zero branch March 17, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt panic
2 participants