Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: don't load prior messages when estimating gas #10548

Closed
wants to merge 1 commit into from

Conversation

arajasek
Copy link
Contributor

Related Issues

Glif nodes are experiencing performance issues. @snissn reported that contention over the message pool locks are causing these RPC calls to be slow.

Proposed Changes

This patch is "wrong", and shouldn't be applied to master, but will likely cause no issues to Glif users.

This patch changes gas estimation to NOT load pending messages from the mempool, eliminating the slow lock contention observed by Snissn. This will make gas used estimation slightly less accurate when there are pending messages from a sender. This is an issue for SPs, and other users sending large numbers of more "complex" messages (not bare transfers), but likely will not affect most Glif users.

This is one of a few simple hacky-patches we can apply to improve overall performance.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 23, 2023 13:48
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack is really hacky.

Almost guaranteed to break things, definitely better to ship #10545

@arajasek arajasek closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants