hack: don't load prior messages when estimating gas #10548
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Glif nodes are experiencing performance issues. @snissn reported that contention over the message pool locks are causing these RPC calls to be slow.
Proposed Changes
This patch is "wrong", and shouldn't be applied to master, but will likely cause no issues to Glif users.
This patch changes gas estimation to NOT load pending messages from the mempool, eliminating the slow lock contention observed by Snissn. This will make gas used estimation slightly less accurate when there are pending messages from a sender. This is an issue for SPs, and other users sending large numbers of more "complex" messages (not bare transfers), but likely will not affect most Glif users.
This is one of a few simple hacky-patches we can apply to improve overall performance.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps