Feat/nv19 #10592
Merged
Feat/nv19 #10592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
feat/nv19
branch
4 times, most recently
from
b91b16c
to
8c9737c
Compare
Update to go-state-types v0.11.0-alpha-1 Introduce dummy v11 actor bundles Make new actors adapters Add upgrade to Upgrade Schedules make jen Update to go-state-types v0.11.0-alpha-2
ZenGround0
reviewed
Mar 29, 2023
| @@ -59,7 +59,11 @@ var UpgradeSkyrHeight = abi.ChainEpoch(-19) | |||
|
|
|||
| var UpgradeSharkHeight = abi.ChainEpoch(-20) | |||
|
|
|||
| var UpgradeHyggeHeight = abi.ChainEpoch(30) | |||
| var UpgradeHyggeHeight = abi.ChainEpoch(-21) | |||
There was a problem hiding this comment.
Since I'm here, why do we go in reverse order (Hygge < Shark) again?
ZenGround0
reviewed
Mar 29, 2023
|
|
||
| var UpgradeLightningHeight = 30 | ||
|
|
||
| var UpgradeThunderHeight = 1000 |
There was a problem hiding this comment.
For devnet testing of nv19 might we want to keep Thunder in the far future by default?
There was a problem hiding this comment.
Probably this only matters for butterfly and calibration and those will be set to realistic testing heights later anyway
There was a problem hiding this comment.
Yeah, this is solely for folks running little 2k devnets on this branch specifically, so I'm not too fussed (calibration etc. will continue to sync well with this branch).
ZenGround0
approved these changes
Mar 29, 2023
29 tasks
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
nv19 is planned for May: filecoin-project/core-devs#123 (reply in thread)
Proposed Changes
Introduces the skeleton for nv19 and nv20 into Lotus without any upgrade epochs, or code / state changes / migrations. Has no effect except on devnets and tests.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps