fix:mpool: prune excess messages before selection #10648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
approved these changes
Apr 11, 2023
arajasek
approved these changes
Apr 11, 2023
|
yes we have a separate fix for that. This is to ensure you can't ever select in an inordinately large set. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed some very high buildup in the mpool, which cannot be cleared fast enough due to pruning cooldown.
This apparently results in messages selection taking too long (10-20s).
This attempts to resolve the issue by eagerly pruning (regardless of cooldown) before selecting, when we have excess messages.