-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:release:update butterfly artifacts and set calibration upgrade heights #10657
Conversation
@@ -73,11 +73,11 @@ const UpgradeSharkHeight = 16800 // 6 days after genesis | |||
// 2023-02-21T16:30:00Z | |||
const UpgradeHyggeHeight = 322354 | |||
|
|||
// ?????????? | |||
const UpgradeLightningHeight = 999999999999999 | |||
// 2023-04-18T16:30:00Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone please check this, I just added 782880 since this is exactly 8 weeks after the last upgrade, I might be off here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, yes.
@@ -73,11 +73,11 @@ const UpgradeSharkHeight = 16800 // 6 days after genesis | |||
// 2023-02-21T16:30:00Z | |||
const UpgradeHyggeHeight = 322354 | |||
|
|||
// ?????????? | |||
const UpgradeLightningHeight = 999999999999999 | |||
// 2023-04-18T16:30:00Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, yes.
build/params_calibnet.go
Outdated
// ?????????????????? | ||
const UpgradeThunderHeight = UpgradeLightningHeight + 1 | ||
// 2023-04-18T20:30:00Z | ||
const UpgradeThunderHeight = UpgradeLightningHeight + 480 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we settle on this? I was thinking of a ~2 day window between Thunder and Lightning, this is much shorter than I think we need for good testing.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps