Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: events: fix race when recording tipsets #10665

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

Stebalien
Copy link
Member

Related Issues

fixes #10664

Proposed Changes

Fix a race when recording tipsets in the mock chainstore.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner April 13, 2023 18:58
@Stebalien Stebalien merged commit 3f74840 into master Apr 14, 2023
@Stebalien Stebalien deleted the steb/fix-event-test-race branch April 14, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A data race in chain/events/events_test.go
2 participants