Validate that FromBlock/ToBlock epoch is indeed a hex value #10780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When calling ETH rpc method
eth_getLogs
and giving it afromBlock
/toBlock
as epoch then return an error if its not in a hexadecimal format (instead of silently passing through and returning nothing or even worse potentially giving incorrect results)Test plan
Verify that giving epoch ("2812200") as decimal returns a nice error:
And that giving the same epoch in hex ("0x2AE928") works: