Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop flaky TestBatchDealInput subcase #10810

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented May 3, 2023

Related Issues

I think we're all aware that this test is flaky. After some investigation:

  • it's specifically the 32-p257B subcase that seems to fail.
  • it never fails locally (ran it in a loop all night)
  • the other 2 subcases never seem to flake
  • it doesn't provide the reason why it fails, just seems to silently crap out after 20-30 seconds and says FAIL command-line-arguments 28.137s.

Proposed Changes

Drop this subcase.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner May 3, 2023 15:54
@magik6k magik6k merged commit ab0e261 into master May 3, 2023
@magik6k magik6k deleted the asr/batch-deal-stop branch May 3, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants