Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_build_ Add checked in file to dockerignore ignore list #10838

Merged
merged 1 commit into from
May 9, 2023

Conversation

ianconsolata
Copy link
Contributor

Related Issues

The Dockerfile would not build on my local machine

Proposed Changes

By adding this submodule to the !gitignore list (which is symlinked to dockerignore), it ensures it is still copied from the local machine into the Docker context before building. Without this, the Docker build will fail in order to prevent the dirty git state from ending up in the go version tag.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner May 5, 2023 13:51
@magik6k magik6k merged commit bd29359 into filecoin-project:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants