Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chainstore: exit early in MaybeTakeHeavierTipset #10839

Merged
merged 1 commit into from
May 5, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented May 5, 2023

Related Issues

I've noticed multiple test failures* resulting from the observer system getting confused because it's asked to "apply" the same tipset as its current head. I'm not entirely sure why this happens, and I'm pretty sure there's an underlying issue (because the tipset question later can't be found in the blockstore for some reason).

BUT, regardless, we can just shortcut if we're ever asked to MaybeTakeHeavierTipset, which looks possible given that sync workers as well as SyncSubmitBlock can lead here.

*example 1, example 2, example 3

Proposed Changes

Exit early.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner May 5, 2023 15:39
@arajasek arajasek enabled auto-merge May 5, 2023 17:56
@arajasek arajasek merged commit fc71ba5 into master May 5, 2023
@arajasek arajasek deleted the asr/deflake-observers branch May 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants