Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deflake eth_balance_test #10847

Merged
merged 1 commit into from
May 9, 2023
Merged

feat: deflake eth_balance_test #10847

merged 1 commit into from
May 9, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented May 9, 2023

Related Issues

This test has been observed to flake, eg: https://app.circleci.com/pipelines/github/filecoin-project/lotus/28677/workflows/bf05c79a-62cf-46ee-b4f7-1aeeeeae02ed/jobs/967190

The test has a faulty assumption that the message lookup height - 2 will always get you a tipset before the relevant message has been included. This is not the case when the tipset after the inclusion tipset is null.

Proposed Changes

The correct way to make this assertion is to actually get heights from the blockchain itself: execution height, inclusion height, "most recent before inclusion height"

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner May 9, 2023 16:37
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@arajasek arajasek enabled auto-merge May 9, 2023 16:44
@arajasek arajasek merged commit 7c98160 into master May 9, 2023
@arajasek arajasek deleted the asr/deflake-ethbalance branch May 9, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants