fix: cli: make redeclare cmd work properly #10860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix an issue where `lotus-miner storage redeclare --all` required an argument - Actually implement the logic to redeclare a single sectors in a single storage path
|
Oh, lint is mad at me. Will fix |
Set drop-missing to true
magik6k
approved these changes
May 16, 2023
magik6k
reviewed
May 16, 2023
There was a problem hiding this comment.
Also should get applied to cmd/lotus-worker/storage.go (we really should somehow deduplicate those files)
Update redeclare cmd on Lotus-Workers
make docsgen-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fix: #10859
Proposed Changes
lotus-miner storage redeclare --allrequired an argumenttrueChecklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps