Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alert: Add FVM_CONCURRENCY alert #10933

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented May 31, 2023

Related Issues

Inspired by #10710

Proposed Changes

Raise an alert in the alert system if the LOTUS_FVM_CONCURRENCY enviroment variable is set higher then 24. Alert the user that this can cause chain sync panics when going over network upgrades/migrations.

Additional Info

Alert will show up in lotus info

Network: localnet-3de9f2f7-de34-41cc-a5fe-0893f2b6e707
StartTime: 4m18s (started at 2023-05-31 09:41:36 -0400 EDT)
Chain: [sync ok] [basefee 100 aFIL] [epoch 328606]
Peers to: [publish messages 0] [publish blocks 0]
⚠ 1 Active alerts (check lotus log alerts)

lotus log alerts

active   process:fvm-concurrency
         last raised at 2023-05-31 09:41:36.969 -0400 EDT; reason: {"message":"LOTUS_FVM_CONCURRENCY is set to a high value that can cause chain sync panics on network migrations/upgrades","recommended":"23 or less during network upgrades","set_value":46}

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Add FVM_CONCURRENCY alert if its set higher then 24
Alert if higher then 24
@rjan90 rjan90 requested a review from a team as a code owner May 31, 2023 13:47
@magik6k magik6k merged commit 6e7dc95 into master May 31, 2023
@magik6k magik6k deleted the feat/fvm-concurrency-alert branch May 31, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants