feat: shed: add a command that spams StateWaitMsg on pending messages #10947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
reviewed
Jun 5, 2023
| go waitMsgFunc() | ||
| } | ||
| select { | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
I might be missing some tricks of the lcli package but shouldn't this be getting cancelled at the end of the writing goroutine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@shrenujbansal and @TippyFlitsUK are testing node perf under stress from a large number of StateWaitMsg requests.
Proposed Changes
Add a shed command that spams these requests for perf testing.
lotus-shed rpc-stress --workers=100will keep 100 StateWaitMsg requests going in perpetuity, assuming there are messages in your mempool (usually needs node to be fully synced).Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps