feat: sector index yugabyte implementation #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 5, 2023 16:15
shrenujbansal
force-pushed
the
sbansal/sector-index
branch
from
1abbebe to
652ee04
Compare
shrenujbansal
changed the title
shrenujbansal
changed the title
shrenujbansal
commented
Aug 9, 2023
shrenujbansal
commented
Aug 9, 2023
magik6k
reviewed
Aug 10, 2023
magik6k
reviewed
Aug 10, 2023
There was a problem hiding this comment.
First pass, looks quite straightforward, the only thing is really addressing the todos, especially the transactional StorageAttach (that has to be correctly transactional, often related paths will be attached by multiple workers at the same time, e.g. when workers are bulk-restarted)
snadrus
reviewed
Aug 10, 2023
snadrus
reviewed
Aug 15, 2023
snadrus
approved these changes
Aug 15, 2023
| return out, nil | ||
| } | ||
|
|
||
| func union(a, b []string) []string { |
magik6k
reviewed
Aug 16, 2023
storage/paths/db_index.go
Outdated
Comment on lines
829
to
832
| _, err := dbi.lock(ctx, sector, read, write) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This probably should retry / backoff / block when we don't get the lock immediately
There was a problem hiding this comment.
Added. Could you review the parameters for the retries and wait time and see if they make sense? @magik6k
added 3 commits
August 16, 2023 10:57
magik6k
reviewed
Aug 17, 2023
|
(also CI seems sad, but not sure if this is related to this PR or feat/sturdypost) |
magik6k
reviewed
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11025
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps