Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ETA to lotus sync wait #11211

Merged
merged 7 commits into from
Sep 15, 2023
Merged

feat: Add ETA to lotus sync wait #11211

merged 7 commits into from
Sep 15, 2023

Conversation

fridrik01
Copy link
Contributor

Related Issues

none

Proposed Changes

This PR adds a ETA indicator to lotus sync wait command which I felt was missing when waiting for my node to finish syncing

Additional Info

image

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

cli/util/eta.go Show resolved Hide resolved
@fridrik01 fridrik01 marked this pull request as ready for review August 26, 2023 17:55
@fridrik01 fridrik01 requested a review from a team as a code owner August 26, 2023 17:55
cli/util/eta.go Show resolved Hide resolved
cli/util/eta.go Outdated Show resolved Hide resolved
cli/util/eta.go Show resolved Hide resolved
cli/util/eta.go Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, although see my comment.

cli/util/eta.go Outdated Show resolved Hide resolved
@Stebalien Stebalien merged commit 26b35b7 into master Sep 15, 2023
@Stebalien Stebalien deleted the add-sync-wait-eta branch September 15, 2023 17:29
@Stebalien
Copy link
Member

"It works". It could probably use some more smoothing (e.g., a longer history), but it works and we can improve it later if we get complaints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants