Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner: log detailed timing breakdown when mining takes longer than the block's timestamp #11228

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

We're looking into reports of missed blocks due to mining taking too long. It's currently hard to analyze what the cause might be, because we only log the detailed breakdown of timing if the entire process was longer than 30s. However, we also want this information if by the time we're done producing the block, we've already reached the block's timestamp

Proposed Changes

Log the detailed breakdown more liberally

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 31, 2023 14:30
Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arajasek arajasek merged commit 9567dee into master Sep 5, 2023
@arajasek arajasek deleted the asr/log-slow-block branch September 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants