Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip TestSealAndVerify3 until it's fixed #11230

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Sep 1, 2023

Related Issues

This test has flaked:

Proposed Changes

We've been talking about it for a while now, have an issue for it (#11110), but haven't made any progress. We need to trust our CI, which means ❌ should mean "you broke something", and we can't do that as this persists.

I propose skipping the test for now, taking the hit to our storage test coverage, and re-enabling if we get around to fixing it.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner September 1, 2023 14:33
@arajasek arajasek merged commit 8ab6eaa into master Sep 6, 2023
@arajasek arajasek deleted the asr/test-seal-and-verify-3-needs-to-stop branch September 6, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants