fix: deps: stop using go-libp2p deprecated peer.ID.Pretty #11263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seem to be more occurrences of this: https://github.com/search?q=repo%3Afilecoin-project%2Flotus%20Pretty()&type=code |
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
Icarus9913
force-pushed
the
libp2p/remove-deprecated-method
branch
from
0e1bf84 to
2a8ea95
Compare
|
All cleaned for lotus. |
marten-seemann
approved these changes
Sep 12, 2023
|
@filecoin-project/lotus-maintainers For some context, we're planning to remove the deprecated method in the next release: libp2p/go-libp2p#2565. Merging this PR early will make updating to next release easier. |
magik6k
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go-libp2ppeerID Pretty method is already deprecated, switch it to call String method.Signed-off-by: Icarus9913 icaruswu66@qq.com
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps