Fix/texts

[criadoperez]

Related Issues

No issue opened

Proposed Changes

Multiple typos on files

[fridrik01]

You need to run "make gen" to address the failing CI test

[criadoperez]

When I run make gen I get the following error that it can't find goimports. Can you please guide me on the right direction to fix this?

chain/actors/policy/policy.go
itests/kit/ensemble_opts_nv.go
go run ./gen/api
goimports -w api
bash: line 1: goimports: command not found
make: *** [Makefile:308: api-gen] Error 127

So then installed goimports with go install golang.org/x/tools/cmd/goimports@latest but didn't solve the problem.

Then when trying to install goimports with go get I get an error:

# go get -v golang.org/x/tools/cmd/goimports
go: github.com/filecoin-project/filecoin-ffi@v0.30.4-0.20220519234331-bfd1f5f9fe38 (replaced by ./extern/filecoin-ffi): reading extern/filecoin-ffi/go.mod: open /go/filecoin-project_lotus/extern/filecoin-ffi/go.mod: no such file or directory

So finally I built and installed goimports from source which made goimports work but make gen now produces the following error:

go run ./gen/api
goimports -w api
goimports -w api
go run ./gen/main.go
chain/consensus/utils.go:12:2: github.com/filecoin-project/filecoin-ffi@v0.30.4-0.20220519234331-bfd1f5f9fe38 (replaced by ./extern/filecoin-ffi): reading extern/filecoin-ffi/go.mod: open /root/filecoin-project_lotus/extern/filecoin-ffi/go.mod: no such file or directory
chain/vm/fvm.go:21:2: github.com/filecoin-project/filecoin-ffi@v0.30.4-0.20220519234331-bfd1f5f9fe38 (replaced by ./extern/filecoin-ffi): reading extern/filecoin-ffi/go.mod: open /root/filecoin-project_lotus/extern/filecoin-ffi/go.mod: no such file or directory
make: *** [Makefile:288: type-gen] Error 1

[fridrik01]

When I run make gen I get the following error that it can't find goimports. Can you please guide me on the right direction to fix this?

After installing goimports with go install, you need to make sure its install location is in your $PATH. You can run go env and sees where that location is under GOPATH. It should probably be in your HOME directory so usually you would just add $HOME/go/bin to your PATH.

[criadoperez]

I had to make some extra steps for it to work, but finally go it. Adding this note here in case it helps anybody else in the future, but it maybe it should be added to the Contribute page.

First, an issue was that this repo has submodules so a standard git clone will give you an error.
Fixed it by using git clone --recurse-submodules when cloning.

Second I had to build the module filecoin-ffi first:

cd extern/filecoin-ffi
make

Note: that requires to install jq first. (apt install jq)

Then a couple of dependencies are required:

apt install libhwloc-dev
apt install ocl-icd-opencl-dev

Finally after all this, make gen works.

[criadoperez]

After running make gen no files are modified.
However I then ran make docsgen-cli which did. Committing these changes.