fix: api: exclude reverted events in eth_getLogs results
#11318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-norden
changed the title
eth_getLogs resultseth_getLogs results
Stebalien
approved these changes
Oct 11, 2023
i-norden
added a commit
to vulcanize/lotus
that referenced
this pull request
Nov 20, 2023
…project#11318) * exclude reverted events from results returned by eth_getLogs * unit test * update CHANGELOG.md
i-norden
added a commit
to vulcanize/lotus
that referenced
this pull request
Dec 11, 2023
…project#11318) * exclude reverted events from results returned by eth_getLogs * unit test * update CHANGELOG.md
i-norden
added a commit
to vulcanize/lotus
that referenced
this pull request
Jan 18, 2024
…project#11318) * exclude reverted events from results returned by eth_getLogs * unit test * update CHANGELOG.md
jonathanface
pushed a commit
to vulcanize/lotus
that referenced
this pull request
Mar 12, 2024
…project#11318) * exclude reverted events from results returned by eth_getLogs * unit test * update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
In Ethereum it is expected that the
eth_getLogsendpoint will only return results for canonical blocks. Non-canonical logs are already being marked correctly in the events.db sqlite database as "reverted", and this adds a missing conditional check on that column when selecting logs from the database.Proposed Changes
Adds a missing conditional check on the "reverted" column when selecting logs from the events index sqlite database.
Additional Info
Necessary for proper subgraph functionality.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps