readme: bump up golang version #11347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridrik01
reviewed
Oct 20, 2023
| @@ -71,10 +71,10 @@ For other distributions you can find the required dependencies [here.](https://l | |||
|
|
|||
| #### Go | |||
|
|
|||
| To build Lotus, you need a working installation of [Go 1.19.12 or higher](https://golang.org/dl/): | |||
| To build Lotus, you need a working installation of [Go 1.20.10 or higher](https://golang.org/dl/): | |||
There was a problem hiding this comment.
Lotus supports Go 1.19.12 so this is not necessarily correct
There was a problem hiding this comment.
$ go version
go version go1.19.2 darwin/arm64
~/code/src/github.com/filecoin-project/lotus (main)
$ make clean all
Makefile:14: Your Golang version is go1.19.2
Makefile:15: *** Update Golang to version to at least 1.20.7. Stop.
See: https://github.com/filecoin-project/lotus/blob/master/GO_VERSION_MIN
I've written 1.20.10 and not 1.20.7 as this is the latest patch version on the 1.20 release.
I believe the bump to Go 1.20.x was made because of QUIC library within libp2p but I might be mistaken on that one.
There was a problem hiding this comment.
Ah, you're right. I was looking at the release branch.
Stebalien
approved these changes
Nov 2, 2023
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
As Lotus is now using Go 1.20 [1], I also upgrade this CI to use 1.20. [1]: filecoin-project/lotus#11347
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
As Lotus is now using Go 1.20 [1], I also upgrade this CI to use 1.20. That also needs a slight reformatting to make go fmt happy. [1]: filecoin-project/lotus#11347
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
As Lotus is now using Go 1.20 [1], also upgrade this CI to use 1.20. This needs slight reformatting to make go fmt happy and the switch from `GODEBUG=cgocheck=2` to `GOEXPERIMENT=cgocheck2`. [1]: filecoin-project/lotus#11347
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
As Lotus is now using Go 1.20 [1], also upgrade this CI to use 1.20. This needs slight reformatting to make go fmt happy. The CircleCI Ubuntu 22.04 image tagged 2023.07.2 is using Go 1.20.4 [2]. Later versions of that image use Go >= 1.21. [1]: filecoin-project/lotus#11347 [2]: https://discuss.circleci.com/t/linux-machine-executor-2023-q3-update/48580
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
As Lotus is now using Go 1.20 [1], also upgrade this CI to use 1.20. This needs slight reformatting to make go fmt happy. The CircleCI Ubuntu 22.04 image tagged 2023.07.2 is using Go 1.20.4 [2]. Later versions of that image use Go >= 1.21 [3]. [1]: filecoin-project/lotus#11347 [2]: https://discuss.circleci.com/t/linux-machine-executor-2023-q3-update/48580 [3]: https://discuss.circleci.com/t/linux-machine-executor-2023-q4-update/49457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating README to ask for Go version 1.20.x instead of 1.19.x