refactor:ffi: replace ClearLayerData with ClearCache #11352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ClearLayerData` FFI call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly what `ClearCache` is doing. This is a first step to remove `ClearLayerData`t also from the FFI again, in order to reduce the API surface.
fridrik01
approved these changes
Oct 27, 2023
|
@vmx build appears to be broken. |
|
My Go-fu is not good enough, don't both functions have the same signature: ClearLayerData: https://github.com/filecoin-project/filecoin-ffi/blob/441fa8e61189dc32c2960c1f8d8ba56269f20366/cgo/proofs.go#L232C5-L232C20 Is this breakage unrelated? |
|
The API is here: I'm not sure why we have two... |
|
Oh, I see. The "proofs" one converts all the types into cgo types. |
|
We could also fix this in the FFI by making |
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
The `ClearLayerData` FFI call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly what `ClearCache` is doing. It was already removed from Lotus in [PR 11352], so that we can remove it here as well (and as a next steps from the Rust side). This reduces the API surface, which is generally a good idea. [PR 11352]: filecoin-project/lotus#11352
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
The `ClearLayerData` FFI call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly what `ClearCache` is doing. It was already removed from Lotus in [PR 11352], so that we can remove it here as well (and as a next steps from the Rust side). This reduces the API surface, which is generally a good idea. [PR 11352]: filecoin-project/lotus#11352
vmx
added a commit
to filecoin-project/filecoin-ffi
that referenced
this pull request
Nov 3, 2023
The `ClearLayerData` FFI call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly what `ClearCache` is doing. It was already removed from Lotus in [PR 11352], so that we can remove it here as well (and as a next steps from the Rust side). This reduces the API surface, which is generally a good idea. [PR 11352]: filecoin-project/lotus#11352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
API surface reduction.
Proposed Changes
The
ClearLayerDataFFI call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly whatClearCacheis doing. This is a first step to removeClearLayerDatat also from the FFI again, in order to reduce the API surface.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps