fix: api: compute gasUsedRatio based on max gas in the tipset #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were computing this based on the max block gas, but this is incorrect. The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough. fixes #10515
fridrik01
approved these changes
Oct 27, 2023
jennijuju
pushed a commit
that referenced
this pull request
Nov 1, 2023
We were computing this based on the max block gas, but this is incorrect. The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough. fixes #10515
Stebalien
pushed a commit
that referenced
this pull request
Nov 1, 2023
We were computing this based on the max block gas, but this is incorrect. The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough. fixes #10515
Stebalien
added a commit
that referenced
this pull request
Nov 1, 2023
We were computing this based on the max block gas, but this is incorrect. The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough. fixes #10515
Merged
jennijuju
pushed a commit
that referenced
this pull request
Nov 2, 2023
We were computing this based on the max block gas, but this is incorrect. The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough. fixes #10515
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #10515
Proposed Changes
When computing the
gasUsedRatioin the Ethereum JSON-RPC APIs useMaxBlockGas * len(TipSet), instead of the max block gas. Otherwise, we get ratios over 1.The new value isn't entirely correct either (we should probably compute an average of the gas used in each block in the tipset?), but it's good enough.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps