Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metric: export Mpool message count #11361

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 31, 2023

Related Issues

Partially #10547. Also nice to have when investigating things like MpoolSelect times, syncing, etc, and its potential correlations with size of the Mpool.

Proposed Changes

Recording the amount of pending messages in the mpool. The metric is updated after messages are removed from the pool (which happens on HeadChange or pruneMessage).

Additional Info

Testing: in localhost:1234/debug/metrics, you now have:

# HELP lotus_mpool_message_count Number of messages in the mpool
# TYPE lotus_mpool_message_count gauge
lotus_mpool_message_count 180

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Record the current size of the mpool and export through Prometheus
@rjan90 rjan90 requested a review from a team as a code owner October 31, 2023 08:38
Record currentSize on addLocked
@Stebalien
Copy link
Member

Could you add a quick entry to the changelog (then merge)?

Update unreleased changelog
@rjan90 rjan90 enabled auto-merge November 3, 2023 13:40
@rjan90 rjan90 merged commit 12b30c0 into master Nov 3, 2023
79 of 87 checks passed
@rjan90 rjan90 deleted the feat/add-mpool-metrics branch November 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants