feat: chain: light-weight patch to fix calibrationnet #11363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 as calibrationnet-buggy.car
arajasek
force-pushed
the
asr/unbork-calibnet
branch
3 times, most recently
from
2c2c7c8 to
ed843a3
Compare
arajasek
force-pushed
the
asr/unbork-calibnet
branch
from
ed843a3 to
6c868fa
Compare
arajasek
changed the title
rjan90
reviewed
Oct 31, 2023
build/params_calibnet.go
Outdated
| @@ -82,6 +82,9 @@ const UpgradeThunderHeight = UpgradeLightningHeight + 3120 | |||
| // 2023-10-19T13:00:00Z | |||
| const UpgradeWatermelonHeight = 1013134 | |||
|
|
|||
| // TODO: SET THE PATCH HEIGHT EPOCH | |||
There was a problem hiding this comment.
My proposal would be: epoch 1070494 - which should be 2023-11-07T13:00:00Z
Stebalien
reviewed
Oct 31, 2023
arajasek
commented
Oct 31, 2023
chain/consensus/filcns/upgrades.go
Outdated
| } | ||
|
|
||
| // This is the hard-coded "buggy" miner actor Code ID | ||
| if inActor.Code != cid.MustParse("bafk2bzacecnh2ouohmonvebq7uughh4h3ppmg4cjsk74dzxlbbtlcij4xbzxq") && inActor.Code != outActor.Code { |
There was a problem hiding this comment.
make these constants
Stebalien
approved these changes
Oct 31, 2023
arajasek
force-pushed
the
asr/unbork-calibnet
branch
2 times, most recently
from
febf78d to
e3ac4ea
Compare
arajasek
force-pushed
the
asr/unbork-calibnet
branch
from
e3ac4ea to
cf9b58a
Compare
arajasek
added a commit
that referenced
this pull request
Oct 31, 2023
* refactor: make GetEmbeddedBuiltinActorsBundle take network bundle name * update calibnet actor bundle to v12.0.0-rc.2, but include v12.0.0-rc.1 as calibrationnet-buggy.car * wip: calibnet unbork migration * calibnet: add buggy miner actor CID to actorMeta * fix incorrect buggy calibnet manifest * make UpgradeWatermelonFixHeight a build param * calibnet patch: check whether network is calibration from init actor state * add sanity checks to the v12 calibnet patch upgrade * address review
arajasek
added a commit
that referenced
this pull request
Oct 31, 2023
* refactor: make GetEmbeddedBuiltinActorsBundle take network bundle name * update calibnet actor bundle to v12.0.0-rc.2, but include v12.0.0-rc.1 as calibrationnet-buggy.car * wip: calibnet unbork migration * calibnet: add buggy miner actor CID to actorMeta * fix incorrect buggy calibnet manifest * make UpgradeWatermelonFixHeight a build param * calibnet patch: check whether network is calibration from init actor state * add sanity checks to the v12 calibnet patch upgrade * address review
This was referenced Nov 1, 2023
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
The calibration test network upgraded to nv21 / actors v12 2 weeks ago. Further testing on the testnet revealed a minor bug in a new feature that has since been patched: filecoin-project/builtin-actors#1455.
Unfortunately, this is consensus-critical, and so needs a coordinated upgrade on the testnet in order to land the new code. This PR proposes a relatively easy way to achieve this.
Proposed Changes
UpgradeWatermelonFixHeightupgrade that ONLY exists for calibrationnet (disabled for all others)actorMetaAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps