Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync: iterate over returned messages directly #11373

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Nov 1, 2023

Related Issues

Every now and then my node seems to get "stuck" syncing, and stays that way for a long while (or until restart).

Proposed Changes

This PR changes our fetchMessages logic to directly process the fetched messages, and request any additional ones needed.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner November 1, 2023 19:36
@Stebalien Stebalien merged commit 29fbfaf into master Nov 1, 2023
@Stebalien Stebalien deleted the asr/debug-sync-issue branch November 1, 2023 22:08
@jennijuju jennijuju mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants