fix syncing new blocks we have locally when not connected to any peers #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
approved these changes
Aug 2, 2019
| @@ -577,3 +577,22 @@ func (cs *ChainStore) blockContainsMsg(blk *types.BlockHeader, msg cid.Cid) (*ty | |||
| func (cs *ChainStore) Blockstore() blockstore.Blockstore { | |||
| return cs.bs | |||
| } | |||
|
|
|||
| func (cs *ChainStore) TryFillTipSet(ts *types.TipSet) (*FullTipSet, error) { | |||
nonsense
pushed a commit
that referenced
this pull request
Nov 6, 2020
This was referenced Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we were always going to blocksync service even if we still had the data locally.
One step better here is likely to just not sync blocks from ourselves over pubsub, but pull them in through a special fast route. But we can do that later (doing things the way we are now has fewer special cases).