Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpwinning: Check inclusion of self-mined blocks in base #11459

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 27, 2023

Related Issues

Part of #11383, probably the final thing

Proposed Changes

In the winning PoSt adder there is now a check which will prevent mining attempts which don't include blocks we have mined ourselves previously in the base

Additional Info

  • Untested, would be good to see if this actually works on a devnet
    • Can mine on tipsets which have blocks we have mined
    • Can mine on tipsets which don't have blocks we have mined

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner November 27, 2023 22:21
@magik6k magik6k requested review from snadrus and mb1896 and removed request for a team November 27, 2023 22:21
@magik6k magik6k merged commit 368ad8d into feat/sturdypost Nov 28, 2023
85 of 89 checks passed
@magik6k magik6k deleted the feat/prov-check-selfexcl branch November 28, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants